[FSSDK-11649] Fix FSC failed tests for CMAB #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mat001
changed the title
raju-opti
requested changes
Jul 17, 2025
raju-opti
requested changes
Jul 23, 2025
raju-opti
approved these changes
Jul 23, 2025
Mat001
added a commit
that referenced
this pull request
Jul 23, 2025
* Fix CMAB error handling to properly propagate error reasons in Decision objects * add cmab cache options to getAllOptions * fix failing fsc tests * add cmab errors file * adjust lowercase * add test * fix error message propagation in resons * add error handling to feature experiment servvice * Add more error handling to feature exper and composite feature service * nil back to err * add reasons message to composite feature service GetDecision * use AddError for reasons * Trigger PR check * remove implicit error handling - PR feedback * use nil instead of err for legacy * fix error format * Fix lint issue with fsc error * Rename error var, lint stuttering issue
Mat001
added a commit
that referenced
this pull request
Aug 11, 2025
* Fix CMAB error handling to properly propagate error reasons in Decision objects * add go-sdk logic to support agent for cmab * cleanup debug statements * add cmab cache options to getAllOptions * fix failing fsc tests * add cmab errors file * adjust lowercase * add test * fix error message propagation in resons * add error handling to feature experiment servvice * Add more error handling to feature exper and composite feature service * nil back to err * add reasons message to composite feature service GetDecision * use AddError for reasons * Trigger PR check * fix cyclomatic complexity by refactoring client.go code * fix lint error * fix lint * Trigger PR check * remove implicit error handling - PR feedback * [FSSDK-11649] Fix FSC failed tests for CMAB (#411) * Fix CMAB error handling to properly propagate error reasons in Decision objects * add cmab cache options to getAllOptions * fix failing fsc tests * add cmab errors file * adjust lowercase * add test * fix error message propagation in resons * add error handling to feature experiment servvice * Add more error handling to feature exper and composite feature service * nil back to err * add reasons message to composite feature service GetDecision * use AddError for reasons * Trigger PR check * remove implicit error handling - PR feedback * use nil instead of err for legacy * fix error format * Fix lint issue with fsc error * Rename error var, lint stuttering issue * add go-sdk logic to support agent for cmab * fix failing fsc tests * adjust lowercase * fix error message propagation in resons * add error handling to feature experiment servvice * Add more error handling to feature exper and composite feature service * Trigger PR check * fix cyclomatic complexity by refactoring client.go code * Trigger PR check * remove implicit error handling - PR feedback * Update license year * Force GitHub refresh * change nill to err in feat exper service * fix tests * add two tests * Force GitHub refresh * Add tests to address coveralls * add couple more tests * few more tests * add test for TrGetCmabDecision * fix formatting * add optional CmabUUID field to OptimizelyDecision for CMAB support * simplify cmab agent support in go-sdk * Add CMAB config struct and constants * fix tests * cleanup * format * add tests for coveralls * add new etst and format * Add CMAB support with config merging and remove CmabUUID from public API * fix low test coverage * fix PR comments * additional fixes to pr comments * Fix whitespace in experiment_bucketer_service_test.go to match master - Restore correct space indentation to match master branch - Addresses coworker comment: 'can we keep this file unchanged?' * update pred endpoint back to preduction, remove inte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in the CMAB error handling path within the GetDecision method. When the CMAB API returns an error, the previous implementation attempted to append reasons from the failed API call to the accumulated reasons list. This caused FSC tests to fail because:
Fix
Modified the error handling path to return a clean Decision object with properly initialized reasons
https://jira.sso.episerver.net/browse/FSSDK-11649